refactor: Improve safety of amortized_iter #16820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a ton of
unsafe
tags and makeUnstableSeries
(nowAmortSeries
) cloneable. If cloned theRc
will be larger than1
and the iterator will invalidate it'sseries_container
and will create a new one. This almost never happens, currently only 1 test hits that.If not the
AmortSeries
, but the underlyingSeries
is cloned we also notice that by checking the underlyingArc
and invalidating the iterators local container.@itamarst FYI.