fix: DATE_PART SQL syntax/parsing, improve some error messages
#16761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters,
MarcoGorelli,
reswqa,
orlp and
universalmind303
as code owners
github-actions
bot
added
fix
alexander-beedie
changed the title
DATE_PART SQL syntaxDATE_PART SQL syntax, improve some error messages
alexander-beedie
changed the title
DATE_PART SQL syntax, improve some error messagesDATE_PART SQL syntax/parsing, improve some error messages
alexander-beedie
force-pushed
the
sql-datepart
branch
from
fc370dc to
a92e1dc
Compare
ritchie46
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves some error messages, raises on invalid use of "WEEK(weekday)" inside
EXTRACT(which is BigQuery-specific and invalid elsewhere), and fixesDATE_PARTparameter order (ouch).