Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python)!: Enforce deprecation of keyword arguments as positional #16755

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jun 6, 2024

Ref #13525

These were deprecated in early 0.20, but I want to expedite the deprecation because:

  • In the case of group_by, it blocks the semantics of using by as a column name in **named_by.
  • In other cases, the deprecation was unlikely to impact many people so we might as well clean up the decorators now.

I kept the decorator implementation and added some tests, as I feel it may come in handy in the future.

@github-actions github-actions bot added breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Jun 6, 2024
@stinodego stinodego marked this pull request as ready for review June 6, 2024 02:32
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.45%. Comparing base (5eb8931) to head (4953f26).

Files Patch % Lines
py-polars/polars/_utils/deprecation.py 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16755      +/-   ##
==========================================
- Coverage   81.45%   81.45%   -0.01%     
==========================================
  Files        1413     1413              
  Lines      185877   185865      -12     
  Branches     2713     2701      -12     
==========================================
- Hits       151407   151395      -12     
  Misses      33979    33979              
  Partials      491      491              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit 4d35be2 into main Jun 6, 2024
14 checks passed
@stinodego stinodego deleted the breaking-depr-more branch June 6, 2024 11:39
@c-peters c-peters added the accepted Ready for implementation label Jun 9, 2024
@stinodego stinodego removed the breaking Change that breaks backwards compatibility label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants