fix(python): Panic on empty df / null List(Categorical) #16730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Object905
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16730 +/- ##
==========================================
- Coverage 81.45% 81.44% -0.01%
==========================================
Files 1413 1413
Lines 186096 186187 +91
Branches 2776 2776
==========================================
+ Hits 151588 151645 +57
- Misses 33988 34022 +34
Partials 520 520 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Jun 5, 2024
| @@ -84,9 +84,12 @@ impl Series { | |||
| #[cfg(feature = "dtype-categorical")] | |||
| dt @ (Categorical(rev_map, ordering) | Enum(rev_map, ordering)) => { | |||
| let cats = UInt32Chunked::from_chunks(name, chunks); | |||
| let rev_map = rev_map | |||
| .clone() | |||
| .unwrap_or_else(|| Arc::new(RevMapping::default())); | |||
There was a problem hiding this comment.
We should assert cats is emtpy if we set an empty rev map.
There was a problem hiding this comment.
Maybe should add it directly in from_cats_and_rev_map_unchecked under cfg(debug_assertions)?
But this seems to be the only place when they're unwrapped, so I added it just here for now.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #16405