Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add field expression as selector with an struct scope #16402

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels May 22, 2024
@ritchie46
Copy link
Member Author

closes #16395

Copy link

codspeed-hq bot commented May 22, 2024

CodSpeed Performance Report

Merging #16402 will improve performances by 16.1%

Comparing field (2616f98) with main (8bc1019)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main field Change
test_groupby_h2oai_q3 11.5 ms 9.9 ms +16.1%

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 93.84615% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.43%. Comparing base (8bc1019) to head (2616f98).

Files Patch % Lines
crates/polars-plan/src/dsl/expr.rs 0.00% 1 Missing ⚠️
...plan/src/logical_plan/conversion/expr_expansion.rs 94.11% 1 Missing ⚠️
crates/polars-plan/src/logical_plan/format.rs 0.00% 1 Missing ⚠️
py-polars/polars/functions/lazy.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16402      +/-   ##
==========================================
+ Coverage   81.40%   81.43%   +0.03%     
==========================================
  Files        1409     1409              
  Lines      184519   184567      +48     
  Branches     2961     2962       +1     
==========================================
+ Hits       150206   150306     +100     
+ Misses      33798    33745      -53     
- Partials      515      516       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 3d9ef69 into main May 22, 2024
28 checks passed
@ritchie46 ritchie46 deleted the field branch May 22, 2024 15:15
@c-peters c-peters added the accepted Ready for implementation label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants