fix(python): raise error when pandas df's some index name duplicates some column name #16023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates column name (#15938)
piri-p
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
…ates column name (#15938) - improve readability
mcrumiller
reviewed
May 2, 2024
mcrumiller
reviewed
May 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16023 +/- ##
=======================================
Coverage 80.91% 80.92%
=======================================
Files 1385 1385
Lines 178224 178227 +3
Branches 3050 3051 +1
=======================================
+ Hits 144212 144227 +15
+ Misses 33522 33512 -10
+ Partials 490 488 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ates column name (#15938) - handle multiindex
|
Thanks for your feedback @mcrumiller ! I have addressed your concerns (update code to handle MultiIndex, moved tests to |
piri-p
changed the title
MarcoGorelli
requested changes
May 2, 2024
| @@ -1020,6 +1020,11 @@ def pandas_to_pydf( | |||
| ) -> PyDataFrame: | |||
| """Construct a PyDataFrame from a pandas DataFrame.""" | |||
| convert_index = include_index and not _pandas_has_default_index(data) | |||
| if convert_index and set(data.index.names).intersection(data.columns): | |||
There was a problem hiding this comment.
Polars converts non-string column names to string
I think a more generic solution is needed, to handle #16025 too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15938 : raise ValueError when converting from pandas DF, whose index name duplicates some column name @MarcoGorelli