Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Decimal types in write_csv/write_json #14209

Merged
merged 4 commits into from
Jun 25, 2024
Merged

feat: Support Decimal types in write_csv/write_json #14209

merged 4 commits into from
Jun 25, 2024

Conversation

flisky
Copy link
Contributor

@flisky flisky commented Feb 2, 2024

No description provided.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Feb 2, 2024
@flisky flisky marked this pull request as draft February 2, 2024 11:20
@flisky flisky marked this pull request as ready for review February 5, 2024 03:10
@stinodego stinodego added the A-dtype-decimal Area: decimal data type label Feb 26, 2024
crates/polars-json/Cargo.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 91.22807% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.95%. Comparing base (4731834) to head (36a416f).
Report is 1 commits behind head on main.

Files Patch % Lines
...s/polars-io/src/csv/write/write_impl/serializer.rs 79.16% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14209   +/-   ##
=======================================
  Coverage   80.94%   80.95%           
=======================================
  Files        1464     1464           
  Lines      191928   191983   +55     
  Branches     2742     2742           
=======================================
+ Hits       155349   155412   +63     
+ Misses      36070    36062    -8     
  Partials      509      509           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julian-J-S
Copy link
Contributor

Any update on this one? Would love to see more decimal support 😊

Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Thank you for the PR. Looks good. Can you add some tests on the python side?

BTW, this will only support json, not csv.

@d-reynol
Copy link

@ritchie46 do you mind taking a look at this? Being able to write decimal to CSV would be quite useful

@Julian-J-S
Copy link
Contributor

Any progress here? 🤓

@flisky
Copy link
Contributor Author

flisky commented Jun 25, 2024

Rebased!

Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you @flisky. Sorry for the delay here.

@ritchie46 ritchie46 merged commit 7a1be3b into pola-rs:main Jun 25, 2024
26 checks passed
@d-reynol
Copy link

Thank you @ritchie46 !

@stinodego stinodego changed the title feat: support decimal in csv/json feat: Support Decimal types in write_csv/write_json Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dtype-decimal Area: decimal data type enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants