-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Decimal types in write_csv/write_json
#14209
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14209 +/- ##
=======================================
Coverage 80.94% 80.95%
=======================================
Files 1464 1464
Lines 191928 191983 +55
Branches 2742 2742
=======================================
+ Hits 155349 155412 +63
+ Misses 36070 36062 -8
Partials 509 509 ☔ View full report in Codecov by Sentry. |
Any update on this one? Would love to see more decimal support 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Thank you for the PR. Looks good. Can you add some tests on the python side?
BTW, this will only support json, not csv.
@ritchie46 do you mind taking a look at this? Being able to write decimal to CSV would be quite useful |
Any progress here? 🤓 |
Rebased! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you @flisky. Sorry for the delay here.
Thank you @ritchie46 ! |
write_csv/write_json
No description provided.