Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polars 0.45.1 does not build on stable #20823

Closed
2 tasks done
FHTMitchell opened this issue Jan 21, 2025 · 1 comment
Closed
2 tasks done

Polars 0.45.1 does not build on stable #20823

FHTMitchell opened this issue Jan 21, 2025 · 1 comment
Labels
bug Something isn't working needs triage Awaiting prioritization by a maintainer rust Related to Rust Polars

Comments

@FHTMitchell
Copy link

FHTMitchell commented Jan 21, 2025

Checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of Polars.

Reproducible example

[package]
name = "polars-test"
version = "0.1.0"
edition = "2021"

[dependencies]
polars = { version = "0.45.1", default-features = false }  # "nightly" isn't a default feature but just to be clear

Log output

❯ cargo build --keep-going
   Compiling polars-row v0.45.1
   Compiling polars-parquet v0.45.1
error[E0658]: use of unstable library feature 'iter_repeat_n'
  --> /home/fmitchel/.cargo/registry/src/index.crates.io-6f17d22bba15001f/polars-row-0.45.1/src/encode.rs:52:9
   |
52 |         std::iter::repeat_n(RowEncodingOptions::default(), columns.len())
   |         ^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #104434 <https://github.com/rust-lang/rust/issues/104434> for more information

error[E0658]: use of unstable library feature 'iter_repeat_n'
   --> /home/fmitchel/.cargo/registry/src/index.crates.io-6f17d22bba15001f/polars-row-0.45.1/src/encode.rs:772:45
    |
772 | ...                   .extend(std::iter::repeat_n(masked_out_write_offset, length));
    |                               ^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #104434 <https://github.com/rust-lang/rust/issues/104434> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `polars-row` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error[E0658]: use of unstable library feature 'is_none_or'
  --> /home/fmitchel/.cargo/registry/src/index.crates.io-6f17d22bba15001f/polars-parquet-0.45.1/src/arrow/read/deserialize/utils/mod.rs:45:45
   |
45 |         if is_optional && page.null_count().is_none_or(|nc| nc != 0) {
   |                                             ^^^^^^^^^^
   |
   = note: see issue #126383 <https://github.com/rust-lang/rust/issues/126383> for more information

error: could not compile `polars-parquet` (lib) due to 1 previous error

Issue description

Polars does not currently compile on the stable toolchain, despite the docs explicitly saying it should be possible.

Expected behavior

Polars compiles on stable.

Installed versions

None
@FHTMitchell FHTMitchell added bug Something isn't working needs triage Awaiting prioritization by a maintainer rust Related to Rust Polars labels Jan 21, 2025
@FHTMitchell
Copy link
Author

Ah sorry I was running and old stable toolchain. Might be worth putting a MSRV in the readme? In any case, I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Awaiting prioritization by a maintainer rust Related to Rust Polars
Projects
None yet
Development

No branches or pull requests

1 participant