assert_frame_not_equal does not raise when input types are different

[henryharbeck]

Checks

• I have checked that this issue has not already been reported.
• I have confirmed this bug exists on the latest version of Polars.

Reproducible example

from polars.testing import assert_frame_not_equal

df1 = pl.DataFrame({"a": [1, 2, 3]})
df2 = pl.DataFrame({"a": [1, 5, 3]})

assert_frame_not_equal(df1, df2.lazy()) # no AssertionError raised

Log output

No response

Issue description

assert_frame_not_equal should raise when the types are not the same

Expected behavior

It should raise the same way this does

from polars.testing import assert_frame_equal

df1 = pl.DataFrame({"a": [1, 2, 3]})

assert_frame_equal(df1, df1.lazy())
# AssertionError: inputs are different (unexpected input types)
# [left]:  DataFrame
# [right]: LazyFrame

Installed versions

main branch

[alexander-beedie]

I see why it's happening... of course technically the frames aren't equal as they are of different types, heh. But that's not what the function is testing, so I agree that it should raise here ;)

[henryharbeck]

technically the frames aren't equal as they are of different types, heh

🤣 you are not wrong

Fix incoming!

[alexander-beedie]

Fix incoming!

Ahh, already committed one 😅
Spotted we had the same issue with assert_series_equal too.

[henryharbeck]

Very fast! Appreciate the quick turnaround!

[mcrumiller]

Spotted we had the same issue with assert_series_equal too.

Was this possible to hit? There is no lazy Series.

[alexander-beedie]

Was this possible to hit? There is no lazy Series.

Yes, as you can hit it on any mismatched type...
For example, this will currently not raise (but should):

from polars.testing import assert_series_not_equal
import polars as pl

s1 = pl.Series([1,2,3])
s2 = "I am a potato"

# does not (currently) raise about the mismatched/invalid input
assert_series_not_equal(s1, s2)