Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: .collect() no longer generates unexpected keywords error. #16525

Closed
2 tasks done
cmdlineluser opened this issue May 27, 2024 · 2 comments
Closed
2 tasks done
Labels
bug Something isn't working P-medium Priority: medium python Related to Python Polars

Comments

@cmdlineluser
Copy link
Contributor

Checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of Polars.

Reproducible example

import polars as pl

pl.LazyFrame().collect(FOO=True)
# shape: (0, 0)
# ┌┐
# ╞╡
# └┘

Log output

No response

Issue description

kwargs were removed from .collect() in #11567

It seems something changed after 0.20.23 which allows unexpected keywords to pass through again.

I'm assuming this was unintended.

Expected behavior

TypeError: LazyFrame.collect() got an unexpected keyword argument 'FOO'

Installed versions

--------Version info---------
Polars:               0.20.30
Index type:           UInt32
Platform:             macOS-13.6.1-arm64-arm-64bit
Python:               3.12.2 (main, Feb  6 2024, 20:19:44) [Clang 15.0.0 (clang-1500.1.0.2.5)]

----Optional dependencies----
adbc_driver_manager:  <not installed>
cloudpickle:          <not installed>
connectorx:           <not installed>
deltalake:            <not installed>
fastexcel:            <not installed>
fsspec:               <not installed>
gevent:               <not installed>
hvplot:               <not installed>
matplotlib:           <not installed>
nest_asyncio:         <not installed>
numpy:                1.26.4
openpyxl:             <not installed>
pandas:               2.2.1
pyarrow:              15.0.2
pydantic:             <not installed>
pyiceberg:            <not installed>
pyxlsb:               <not installed>
sqlalchemy:           <not installed>
xlsx2csv:             <not installed>
xlsxwriter:           <not installed>
@cmdlineluser cmdlineluser added bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars labels May 27, 2024
@stinodego
Copy link
Member

I see this:

callback = _kwargs.get("post_opt_callback")

This should not be done with kwargs but with a private keyword arg.

@stinodego stinodego added P-medium Priority: medium and removed needs triage Awaiting prioritization by a maintainer labels May 27, 2024
@github-project-automation github-project-automation bot moved this to Ready in Backlog May 27, 2024
@cmdlineluser
Copy link
Contributor Author

Fixed by #19618

@github-project-automation github-project-automation bot moved this from Ready to Done in Backlog Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P-medium Priority: medium python Related to Python Polars
Projects
Archived in project
Development

No branches or pull requests

2 participants