Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exception base class on the Python side #13399

Closed
indigoviolet opened this issue Jan 3, 2024 · 1 comment · Fixed by #13615
Closed

Add exception base class on the Python side #13399

indigoviolet opened this issue Jan 3, 2024 · 1 comment · Fixed by #13615
Assignees
@stinodego
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature

Comments

@indigoviolet
Copy link

Description

Based on https://github.com/pola-rs/polars/blob/main/py-polars/polars/exceptions.py, it does not. It would be useful to define a polars.PolarsBaseException that can be used to catch all errors from polars without catching Exception
@indigoviolet indigoviolet added the enhancement New feature or an improvement of an existing feature label Jan 3, 2024
@stinodego
Copy link
Member

stinodego commented Jan 3, 2024 •
edited
Loading

No, but I will add one. There might already be an issue for it 🤔

EDIT: I can't find it, so I will accept this issue.

This needs to be implemented in PyO3. Context:
PyO3/pyo3#3452
PyO3/pyo3#3475

@stinodego stinodego changed the title Does Polars have a base exception class to catch all exceptions from polars? Add exception base class on the Python side Jan 3, 2024
@stinodego stinodego added the accepted Ready for implementation label Jan 3, 2024
@stinodego stinodego mentioned this issue Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stinodego stinodego

Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(python): Add base PolarsError and PolarsWarning class pola-rs/polars
2 participants
@indigoviolet @stinodego