chore: Remove useless SeriesTrait::get implementations (#20136)

pola-rs · Dec 3, 2024 · d629cae · d629cae
1 parent 9b91418
commit d629cae
Show file tree

Hide file tree

Showing 17 changed files with 7 additions and 69 deletions.
diff --git a/crates/polars-core/src/series/implementations/array.rs b/crates/polars-core/src/series/implementations/array.rs
@@ -145,10 +145,6 @@ impl SeriesTrait for SeriesWrap<ArrayChunked> {
         self.0.cast_with_options(dtype, options)
     }
 
-    fn get(&self, index: usize) -> PolarsResult<AnyValue> {
-        self.0.get_any_value(index)
-    }
-
     #[inline]
     unsafe fn get_unchecked(&self, index: usize) -> AnyValue {
         self.0.get_any_value_unchecked(index)

diff --git a/crates/polars-core/src/series/implementations/binary.rs b/crates/polars-core/src/series/implementations/binary.rs
@@ -174,10 +174,6 @@ impl SeriesTrait for SeriesWrap<BinaryChunked> {
         self.0.cast_with_options(dtype, options)
     }
 
-    fn get(&self, index: usize) -> PolarsResult<AnyValue> {
-        self.0.get_any_value(index)
-    }
-
     #[inline]
     unsafe fn get_unchecked(&self, index: usize) -> AnyValue {
         self.0.get_any_value_unchecked(index)

diff --git a/crates/polars-core/src/series/implementations/binary_offset.rs b/crates/polars-core/src/series/implementations/binary_offset.rs
@@ -146,10 +146,6 @@ impl SeriesTrait for SeriesWrap<BinaryOffsetChunked> {
         self.0.cast_with_options(dtype, options)
     }
 
-    fn get(&self, index: usize) -> PolarsResult<AnyValue> {
-        self.0.get_any_value(index)
-    }
-
     #[inline]
     unsafe fn get_unchecked(&self, index: usize) -> AnyValue {
         self.0.get_any_value_unchecked(index)

diff --git a/crates/polars-core/src/series/implementations/boolean.rs b/crates/polars-core/src/series/implementations/boolean.rs
@@ -208,10 +208,6 @@ impl SeriesTrait for SeriesWrap<BooleanChunked> {
         self.0.cast_with_options(dtype, options)
     }
 
-    fn get(&self, index: usize) -> PolarsResult<AnyValue> {
-        self.0.get_any_value(index)
-    }
-
     #[inline]
     unsafe fn get_unchecked(&self, index: usize) -> AnyValue {
         self.0.get_any_value_unchecked(index)

diff --git a/crates/polars-core/src/series/implementations/categorical.rs b/crates/polars-core/src/series/implementations/categorical.rs
@@ -223,10 +223,6 @@ impl SeriesTrait for SeriesWrap<CategoricalChunked> {
         self.0.cast_with_options(dtype, options)
     }
 
-    fn get(&self, index: usize) -> PolarsResult<AnyValue> {
-        self.0.get_any_value(index)
-    }
-
     #[inline]
     unsafe fn get_unchecked(&self, index: usize) -> AnyValue {
         self.0.get_any_value_unchecked(index)

diff --git a/crates/polars-core/src/series/implementations/date.rs b/crates/polars-core/src/series/implementations/date.rs
@@ -266,10 +266,6 @@ impl SeriesTrait for SeriesWrap<DateChunked> {
         }
     }
 
-    fn get(&self, index: usize) -> PolarsResult<AnyValue> {
-        self.0.get_any_value(index)
-    }
-
     #[inline]
     unsafe fn get_unchecked(&self, index: usize) -> AnyValue {
         self.0.get_any_value_unchecked(index)

diff --git a/crates/polars-core/src/series/implementations/datetime.rs b/crates/polars-core/src/series/implementations/datetime.rs
@@ -260,10 +260,6 @@ impl SeriesTrait for SeriesWrap<DatetimeChunked> {
         }
     }
 
-    fn get(&self, index: usize) -> PolarsResult<AnyValue> {
-        self.0.get_any_value(index)
-    }
-
     #[inline]
     unsafe fn get_unchecked(&self, index: usize) -> AnyValue {
         self.0.get_any_value_unchecked(index)

diff --git a/crates/polars-core/src/series/implementations/decimal.rs b/crates/polars-core/src/series/implementations/decimal.rs
@@ -294,10 +294,6 @@ impl SeriesTrait for SeriesWrap<DecimalChunked> {
         self.0.cast_with_options(dtype, cast_options)
     }
 
-    fn get(&self, index: usize) -> PolarsResult<AnyValue> {
-        self.0.get_any_value(index)
-    }
-
     #[inline]
     unsafe fn get_unchecked(&self, index: usize) -> AnyValue {
         self.0.get_any_value_unchecked(index)

diff --git a/crates/polars-core/src/series/implementations/duration.rs b/crates/polars-core/src/series/implementations/duration.rs
@@ -380,10 +380,6 @@ impl SeriesTrait for SeriesWrap<DurationChunked> {
         self.0.cast_with_options(dtype, cast_options)
     }
 
-    fn get(&self, index: usize) -> PolarsResult<AnyValue> {
-        self.0.get_any_value(index)
-    }
-
     #[inline]
     unsafe fn get_unchecked(&self, index: usize) -> AnyValue {
         self.0.get_any_value_unchecked(index)

diff --git a/crates/polars-core/src/series/implementations/floats.rs b/crates/polars-core/src/series/implementations/floats.rs
@@ -254,10 +254,6 @@ macro_rules! impl_dyn_series {
                 self.0.cast_with_options(dtype, cast_options)
             }
 
-            fn get(&self, index: usize) -> PolarsResult<AnyValue> {
-                self.0.get_any_value(index)
-            }
-
             #[inline]
             unsafe fn get_unchecked(&self, index: usize) -> AnyValue {
                 self.0.get_any_value_unchecked(index)

diff --git a/crates/polars-core/src/series/implementations/list.rs b/crates/polars-core/src/series/implementations/list.rs
@@ -148,10 +148,6 @@ impl SeriesTrait for SeriesWrap<ListChunked> {
         self.0.cast_with_options(dtype, cast_options)
     }
 
-    fn get(&self, index: usize) -> PolarsResult<AnyValue> {
-        self.0.get_any_value(index)
-    }
-
     #[inline]
     unsafe fn get_unchecked(&self, index: usize) -> AnyValue {
         self.0.get_any_value_unchecked(index)

diff --git a/crates/polars-core/src/series/implementations/mod.rs b/crates/polars-core/src/series/implementations/mod.rs
@@ -326,10 +326,6 @@ macro_rules! impl_dyn_series {
                 self.0.cast_with_options(dtype, options)
             }
 
-            fn get(&self, index: usize) -> PolarsResult<AnyValue> {
-                self.0.get_any_value(index)
-            }
-
             #[inline]
             unsafe fn get_unchecked(&self, index: usize) -> AnyValue {
                 self.0.get_any_value_unchecked(index)

diff --git a/crates/polars-core/src/series/implementations/null.rs b/crates/polars-core/src/series/implementations/null.rs
@@ -222,11 +222,6 @@ impl SeriesTrait for NullChunked {
         NullChunked::new(self.name.clone(), length).into_series()
     }
 
-    fn get(&self, index: usize) -> PolarsResult<AnyValue> {
-        polars_ensure!(index < self.len(), oob = index, self.len());
-        Ok(AnyValue::Null)
-    }
-
     unsafe fn get_unchecked(&self, _index: usize) -> AnyValue {
         AnyValue::Null
     }

diff --git a/crates/polars-core/src/series/implementations/string.rs b/crates/polars-core/src/series/implementations/string.rs
@@ -179,10 +179,6 @@ impl SeriesTrait for SeriesWrap<StringChunked> {
         self.0.cast_with_options(dtype, cast_options)
     }
 
-    fn get(&self, index: usize) -> PolarsResult<AnyValue> {
-        self.0.get_any_value(index)
-    }
-
     #[inline]
     unsafe fn get_unchecked(&self, index: usize) -> AnyValue {
         self.0.get_any_value_unchecked(index)

diff --git a/crates/polars-core/src/series/implementations/struct_.rs b/crates/polars-core/src/series/implementations/struct_.rs
@@ -150,10 +150,6 @@ impl SeriesTrait for SeriesWrap<StructChunked> {
         self.0.cast_with_options(dtype, cast_options)
     }
 
-    fn get(&self, index: usize) -> PolarsResult<AnyValue> {
-        self.0.get_any_value(index)
-    }
-
     unsafe fn get_unchecked(&self, index: usize) -> AnyValue {
         self.0.get_any_value_unchecked(index)
     }

diff --git a/crates/polars-core/src/series/implementations/time.rs b/crates/polars-core/src/series/implementations/time.rs
@@ -228,10 +228,6 @@ impl SeriesTrait for SeriesWrap<TimeChunked> {
         }
     }
 
-    fn get(&self, index: usize) -> PolarsResult<AnyValue> {
-        self.0.get_any_value(index)
-    }
-
     #[inline]
     unsafe fn get_unchecked(&self, index: usize) -> AnyValue {
         self.0.get_any_value_unchecked(index)

diff --git a/crates/polars-core/src/series/series_trait.rs b/crates/polars-core/src/series/series_trait.rs
@@ -398,7 +398,12 @@ pub trait SeriesTrait:
 
     /// Get a single value by index. Don't use this operation for loops as a runtime cast is
     /// needed for every iteration.
-    fn get(&self, _index: usize) -> PolarsResult<AnyValue>;
+    fn get(&self, index: usize) -> PolarsResult<AnyValue> {
+        polars_ensure!(index < self.len(), oob = index, self.len());
+        // SAFETY: Just did bounds check
+        let value = unsafe { self.get_unchecked(index) };
+        Ok(value)
+    }
 
     /// Get a single value by index. Don't use this operation for loops as a runtime cast is
     /// needed for every iteration.
@@ -407,9 +412,7 @@ pub trait SeriesTrait:
     ///
     /// # Safety
     /// Does not do any bounds checking
-    unsafe fn get_unchecked(&self, _index: usize) -> AnyValue {
-        invalid_operation_panic!(get_unchecked, self)
-    }
+    unsafe fn get_unchecked(&self, _index: usize) -> AnyValue;
 
     fn sort_with(&self, _options: SortOptions) -> PolarsResult<Series> {
         polars_bail!(opq = sort_with, self._dtype());