Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox + Photon bug #6103

Closed
5 tasks done
joefulgham opened this issue Nov 7, 2018 · 1 comment
Closed
5 tasks done

Lightbox + Photon bug #6103

joefulgham opened this issue Nov 7, 2018 · 1 comment
Labels
compatibility/3rd-party Indicates a compatibility problem with a 3rd-party plugin or theme. status/merged Indicates when a Pull Request has been merged to a Release.
Milestone

Comments

@joefulgham
Copy link

joefulgham commented Nov 7, 2018

Prerequisites

  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • The issue still exists against the latest stable version of Elementor.

Description

Elementor's Lightbox code doesn't recognize images with ?ssl=1 at the end of their URLs as images, so the Lightbox doesn't trigger on links to them.

Jetpack's Photon (CDN image hosting) automatically adds ?ssl=1 of images, so when Jetpack is enabled (on an SSL site, I suppose) the Lightbox no longer functions.

Steps to reproduce

Enable Jetpack & its Photon option.
Create Image element with Lightbox enabled on an SSL site.
Lightbox works fine in the Elementor editor (where ?ssl=1 isn't added by Jetpack) but fails on the live site, where ?ssl=1 is added.

Disabling the Photon option removes the ?ssl=1 and Lightbox functionality works again.

Isolating the problem

  • This bug happens with only Elementor plugin active (and Elementor Pro).
  • This bug happens with a default WordPress theme active.
  • I can reproduce this bug consistently using the steps above.

Environment

System Info ``` N/A ```
@joefulgham
Copy link
Author

I've found a similar bug with another Lightbox plugin, plus a solution here:

https://wordpress.org/support/topic/url-with-ssl1-fancybox-doesnt-open/

@bainternet bainternet added the compatibility/3rd-party Indicates a compatibility problem with a 3rd-party plugin or theme. label Nov 8, 2018
@arielk arielk added the status/merged Indicates when a Pull Request has been merged to a Release. label Nov 8, 2018
@arielk arielk added this to the 2.3.0 milestone Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility/3rd-party Indicates a compatibility problem with a 3rd-party plugin or theme. status/merged Indicates when a Pull Request has been merged to a Release.
Projects
None yet
Development

No branches or pull requests

3 participants