Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in page settings are saved automatically issue #3510

Closed
kokers opened this issue Feb 19, 2018 · 4 comments
Closed

Changes in page settings are saved automatically issue #3510

kokers opened this issue Feb 19, 2018 · 4 comments
Labels
bug Indicates a bug with one or multiple components.
Milestone

Comments

@kokers
Copy link

kokers commented Feb 19, 2018

I've created "Cover" section in page settings where user can type their tagline and choose image. This is something I can't do with widget because cover is outside "the_content".

The issue is that values are saved automatically when they should be saved after hitting "Update" button. The same goes when choosing a page template or with controls in "style" tab. Users might not be aware, that all changes made in page settings are visible for viewers the moment they change something. This is a real issue, because for example user might experiment with background color, and their customers might visit website in that moment. Or with custom control like text/textarea while they are still typing, and partial content will be shown to customer.

And there is no way to get back to previous settings because, there are no changes logged in history. So in case someone change their mind, all changes are live anyway, and there is no way to revert back.

Changes made in page settings shouldn't be saved automatically.

@tristanleboss
Copy link

tristanleboss commented Feb 19, 2018

Yes, I detected this too and this is clearly really dangerous: it's a critical bug ( @KingYes ) ! You don't expect Elementor to do any change to the post until you hit the "Update" button.

@norewp
Copy link

norewp commented Feb 20, 2018

I second this request - it has been a pain to extend Elementor in these regions.

@bainternet bainternet added the bug Indicates a bug with one or multiple components. label Feb 20, 2018
@bainternet bainternet added this to the 2.0.0 milestone Feb 20, 2018
@bainternet
Copy link
Contributor

We have addressed this in version 2.0.0.

@tristanleboss
Copy link

tristanleboss commented Feb 20, 2018

Great. Any ETA for 2.0.0 release? If this date is not yet known or far away, couldn't this fix be backported to 1.9.6? Indeed, that's a serious issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates a bug with one or multiple components.
Projects
None yet
Development

No branches or pull requests

4 participants