You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
A clear and concise description of what the bug is.
I accidentally changed the type of $queries for executeSelectRaw from list<string> to array{list<string>}. The query was serialized and unserialized in the worker send queue as-is, and only caused a crash when actually running in MysqliThread::executeQuery. This only crashes the worker thread, but the server keeps on running. If this happens in production scenario, all SQL workers will get stuck and all queries will end up taking forever to run, and server admin has no way to know what's wrong except by reading the crash output on the stdout, which does not even get sent to the PocketMine logger.
Describe the bug
A clear and concise description of what the bug is.
I accidentally changed the type of
$queries
forexecuteSelectRaw
fromlist<string>
toarray{list<string>}
. The query was serialized and unserialized in the worker send queue as-is, and only caused a crash when actually running inMysqliThread::executeQuery
. This only crashes the worker thread, but the server keeps on running. If this happens in production scenario, all SQL workers will get stuck and all queries will end up taking forever to run, and server admin has no way to know what's wrong except by reading the crash output on the stdout, which does not even get sent to the PocketMine logger.Environment
hub.docker.com/pmmp/pocketmine-mp:4.0.2
OS: Ubuntu
PocketMine version: 4.0.2
The text was updated successfully, but these errors were encountered: