Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server does not cascade shutdown or recover when SQL workers crash #71

Open
SOF3 opened this issue Dec 14, 2021 · 3 comments
Open

Server does not cascade shutdown or recover when SQL workers crash #71

SOF3 opened this issue Dec 14, 2021 · 3 comments
Labels

Comments

@SOF3
Copy link
Member

SOF3 commented Dec 14, 2021

Describe the bug
A clear and concise description of what the bug is.

I accidentally changed the type of $queries for executeSelectRaw from list<string> to array{list<string>}. The query was serialized and unserialized in the worker send queue as-is, and only caused a crash when actually running in MysqliThread::executeQuery. This only crashes the worker thread, but the server keeps on running. If this happens in production scenario, all SQL workers will get stuck and all queries will end up taking forever to run, and server admin has no way to know what's wrong except by reading the crash output on the stdout, which does not even get sent to the PocketMine logger.

Environment
hub.docker.com/pmmp/pocketmine-mp:4.0.2
OS: Ubuntu
PocketMine version: 4.0.2

@SOF3 SOF3 added the bug label Dec 14, 2021
@dktapps
Copy link
Member

dktapps commented Dec 14, 2021

If you're using Worker it won't actually crash, it'll just bork the task involved. pmmp/ext-pmmpthread#34

@SOF3
Copy link
Member Author

SOF3 commented Dec 14, 2021

It isn't a worker. Just a thread on a wait loop.

Don't ask me why I didn't use a Worker.

@dktapps
Copy link
Member

dktapps commented May 16, 2023

This will be fixed by the release of pmmpthread 6.0.0 (pmmp/ext-pmmpthread@5c595c1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants