Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): uninstall nodemon #817

Merged
merged 6 commits into from
Nov 27, 2018
Merged

fix(security): uninstall nodemon #817

merged 6 commits into from
Nov 27, 2018

Conversation

lautarodragan
Copy link
Member

PR Process - PR Review Checklist

Release

Semantic release is enabled for this repository. Make sure you follow the right commit message convention.
We're using semantic-release's default — Angular Commit Message Conventions.

Description of Changes

See dominictarr/event-stream#116

$ npm ls event-stream flatmap-stream
@po.et/node@1.0.3 /.../poet/node
└─┬ nodemon@1.18.6
  └─┬ pstree.remy@1.1.0
    └─┬ ps-tree@1.1.0
      └─┬ event-stream@3.3.6 
        └── flatmap-stream@0.1.1 

$ npm uninstall nodemon
npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but npm-shrinkwrap.json was generated for lockfileVersion@0. I'll try to do my best with it!
removed 95 packages, updated 6 packages and audited 20148 packages in 23.041s
found 1 low severity vulnerability
  run `npm audit fix` to fix them, or `npm audit` for details

$ npm ls event-stream flatmap-stream
@po.et/node@1.0.3 /.../poet/node
└── (empty)

HackerOne report: https://hackerone.com/reports/450006

@lautarodragan lautarodragan merged commit f6b75ac into master Nov 27, 2018
@lautarodragan lautarodragan deleted the uninstall-nodemon branch November 27, 2018 00:17
@poet-ci
Copy link

poet-ci commented Nov 27, 2018

🎉 This PR is included in version 2.10.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants