fix(semantic-release): resolve semantic release issues #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 25, 2018 09:39
…ravis-deploy-once
.travis.yml
Outdated
| @@ -17,8 +17,7 @@ env: | |||
|
|
|||
| install: | |||
| - DC_FILES="-f docker-compose.yml -f docker-compose.ci.yml" | |||
| - docker-compose $DC_FILES build | |||
| - docker images | |||
| #- docker-compose $DC_FILES build | |||
There was a problem hiding this comment.
I thought it was best to remove the build arg, because docker-compose up will build the container if does not exist. Since in travis, the environments are ephemeral, its safe to remove the explicit build and let docker-compose up handle this.
| @@ -6,7 +6,7 @@ set -o pipefail | |||
| # always tag on git hash | |||
| TAG="v-$(git log -1 --pretty=%h)-beta" | |||
|
|
|||
| docker build -t "${REPO}":"${TAG}" . | |||
There was a problem hiding this comment.
Since are already building a container, and running the tests in that container, it makes no sense to have to rebuild it, rather tag it as required and pushed. This should speed up the build times a bit as well
geoffturk
approved these changes
Oct 25, 2018
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Process - PR Review Checklist
Release
Description of Changes
Fixes #637
The
language: minimaltravis environment does not have npm installed, causing semantic release not to run. Also having the semantic-release step inafter_deploymeant that even though it was failing, the job was still passing. The travis-deploy-once package is also not needed since we are running the semantic-release inside a docker container, and thetravis-deploy-oncewill not run and throughs an error if being run no in Travis.