fix: Update create-claim script to use createACDClaim #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwicks31
changed the title
|
What are the package.json and package-lock.json files in here for? |
|
@warrenv I had to add |
krobi64
approved these changes
Oct 23, 2018
scripts/CreateClaim.ts
Outdated
|
|
||
| const main = async () => { | ||
| const attributes = { | ||
| name: process.argv[2] || 'testing claim', | ||
| author: process.argv[3] || 'the tester', | ||
| } | ||
| const client = new Client() | ||
| const claim = await createClaim(PrivateKeyACD, ClaimType.Work, attributes) | ||
| const claim = await createACDClaim(attributes); |
Closed
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Process - PR Review Checklist
Release
Semantic release is enabled for this repository. Make sure you follow the right commit message convention.
We're using semantic-release's default — Angular Commit Message Conventions.
Description of Changes
Fixes #625
The create-claim script broke when updating to poet-js v5.0.5.
Moved create[Type of Claim]Claim functions to tests/helpers/utils so that create-claim script can use them without triggering the setUpClaims script.