-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update README #622
fix: update README #622
Conversation
README.md
Outdated
``` | ||
|
||
The `publicKey` field must be set to the public part of a key pair you own. You'll need the corresponding private key to prove this claim was generated by you. | ||
The `issuer` field contains the public part of a key pair you own. You'll need the corresponding private key to prove | ||
this claim was generated by you. Frost will generate an issuer for your account, or you can use `@poet/poet-js` to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we are currently doing so elsewhere, but the node is meant as a base for other people to build from as well, so I don't think we should mention Frost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [na/] Tested changes manually
- [na/] Checked accidental architectural/style changes
- Reviewed entire diff
- [n/a] Unit tests
- Documentation
- Filenames and locations
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was supposed to be an approval not a comment :)
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
PR Process - PR Review Checklist
Release
Semantic release is enabled for this repository. Make sure you follow the right commit message convention.
We're using semantic-release's default — Angular Commit Message Conventions.
Description of Changes
update README to reflect changes in node