Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype view updates from JSON for 2.7 add new #4020

Closed
pglewis opened this issue Mar 2, 2017 · 5 comments
Closed

Prototype view updates from JSON for 2.7 add new #4020

pglewis opened this issue Mar 2, 2017 · 5 comments
Assignees
@sc0ttkclark @pglewis
Labels
Type: Feature Features that add entirely new functionality that was not there before
Milestone
Pods 2.7

Comments

@pglewis
Copy link
Contributor

pglewis commented Mar 2, 2017 •
edited
Loading

Related: #3309

Part of #3364
@pglewis pglewis self-assigned this Mar 2, 2017
@pglewis pglewis added the Type: Feature Features that add entirely new functionality that was not there before label Mar 2, 2017
@pglewis pglewis added this to the Pods 2.7 milestone Mar 2, 2017
@pglewis pglewis mentioned this issue Mar 2, 2017
Closed
16 tasks
@pglewis
Copy link
Contributor Author

pglewis commented Mar 7, 2017 •
edited
Loading

This should be done; no PR involved, this is just an example of returning the data and refreshing the view.

commit: 0a02fbc

@pglewis pglewis added the Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) label Mar 7, 2017
@sc0ttkclark
Copy link
Member

I've got everything in there for posts, terms, users, and pod forms. The only thing remaining there is to handle the JS saving process that terms have which is unique to any of the others. In the future there will be more JS things in core so it'll have to be less than hacky.

That's all that's left though.

@sc0ttkclark sc0ttkclark self-assigned this Apr 6, 2017
@sc0ttkclark
Copy link
Member

Edit links can be used for modals too now, just need to flesh out onChildviewEditClick in _src/pick/pick.js and add the event handler on the edit links in that modal.

@ghost ghost removed the Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) label Apr 6, 2017
@sc0ttkclark sc0ttkclark reopened this Apr 10, 2017
@sc0ttkclark
Copy link
Member

Needs PR and merge into 2.7

@sc0ttkclark
Copy link
Member

https://github.com/pods-framework/pods/tree/feature/4020-view-update-prototype

@sc0ttkclark sc0ttkclark mentioned this issue Apr 11, 2017
Merged
1 task
@pglewis pglewis closed this as completed May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sc0ttkclark sc0ttkclark

@pglewis pglewis

Labels
Type: Feature Features that add entirely new functionality that was not there before
Projects
None yet
Milestone
Pods 2.7
Development

No branches or pull requests
2 participants
@sc0ttkclark @pglewis