Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Util::Application::getApplicationPath() and findAppConfigFile() protected #4630

Closed
aleks-f opened this issue Aug 10, 2024 · 1 comment · Fixed by #4661
Closed

Make Util::Application::getApplicationPath() and findAppConfigFile() protected #4630

aleks-f opened this issue Aug 10, 2024 · 1 comment · Fixed by #4661
Assignees

Comments

@aleks-f
Copy link
Member

aleks-f commented Aug 10, 2024

Is your feature request related to a problem? Please describe.
Application loads config files and forgets which file(s) it has loaded.

Describe the solution you'd like
Make Application::getApplicationPath() and Application::findAppConfigFile() protected so that inheriting classes can utilize them to find the default config file name (when it wasn't specified on the command line) and retain it in the runtime config.

@aleks-f aleks-f added this to the Release 1.14.0 milestone Aug 10, 2024
@aleks-f aleks-f self-assigned this Aug 10, 2024
@aleks-f aleks-f added this to 1.14 Aug 10, 2024
@siren186
Copy link
Member

siren186 commented Sep 7, 2024

@aleks-f Consider about this PR #4661

@aleks-f aleks-f moved this to In Progress in 1.14 Sep 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in 1.14 Sep 11, 2024
@aleks-f aleks-f added the fixed label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants