Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fixed height for card chain blocks and card chain transactions. #2679

Merged
merged 6 commits into from
Sep 9, 2019

Conversation

YegorSan
Copy link
Contributor

@YegorSan YegorSan commented Sep 7, 2019

This PR is related to #2675 issue.

Motivation

Fixed height for card chain blocks and card chain transactions requested.

Changelog

Enhancements

Added fixed height for card chain blocks and transactions.
Screenshot (1)

Checklist for your PR

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YegorSan @pashagonchar

I have to reject 👇

Screenshot 2019-09-08 at 11 38 04

screencapture-localhost-4000-2019-09-08-11_42_36

@YegorSan
Copy link
Contributor Author

YegorSan commented Sep 9, 2019

@vbaranov Hello Victor. I've created new loaders for block chain container:
Light mode:
Screenshot (loaderlight)
Dark mode:
Screenshot (loaderdark)

Added two more loaders to transactions container:
transactionblock

Fixed issue with height (added fixed min height and auto max height).

Please review. Thank's in advance.

@YegorSan
Copy link
Contributor Author

YegorSan commented Sep 9, 2019

@vbaranov I also have a question regarding gettext issue. Each time I pushing new commit, issue is appearing. First commit - everything is ok, but next one already coming with gettext issue. I know that fix for that issue is pretty simple, but maybe you tell me what can be a reason of such situation, and possibly I can prevent it for future. Thank you.

@vbaranov
Copy link
Member

vbaranov commented Sep 9, 2019

@YegorSan every time you adding/removing lines in the Elixir templates you need to change the number of line for the localization string in the internationalization files. This is why with every change you need to run https://poanetwork.github.io/blockscout/#/internationalization?id=internationalization. Please fix gettext issue. PR looks good.

@YegorSan
Copy link
Contributor Author

YegorSan commented Sep 9, 2019

@vbaranov Ok. Thank you so much for information Victor. I've just wondered if I am doing something wrong. Will fix gettext issue , and push update shortly.

@YegorSan
Copy link
Contributor Author

YegorSan commented Sep 9, 2019

@vbaranov Re-added internationalization.

@vbaranov vbaranov self-requested a review September 9, 2019 19:45
@vbaranov vbaranov merged commit 3ccbb1b into blockscout:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants