-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fixed height for card chain blocks and card chain transactions. #2679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…to transaction card, fixed height issue.
@vbaranov Hello Victor. I've created new loaders for block chain container: Added two more loaders to transactions container: Fixed issue with height (added fixed min height and auto max height). Please review. Thank's in advance. |
@vbaranov I also have a question regarding gettext issue. Each time I pushing new commit, issue is appearing. First commit - everything is ok, but next one already coming with gettext issue. I know that fix for that issue is pretty simple, but maybe you tell me what can be a reason of such situation, and possibly I can prevent it for future. Thank you. |
@YegorSan every time you adding/removing lines in the Elixir templates you need to change the number of line for the localization string in the internationalization files. This is why with every change you need to run https://poanetwork.github.io/blockscout/#/internationalization?id=internationalization. Please fix |
@vbaranov Ok. Thank you so much for information Victor. I've just wondered if I am doing something wrong. Will fix gettext issue , and push update shortly. |
… into card-chain-block-fix
@vbaranov Re-added internationalization. |
This PR is related to #2675 issue.
Motivation
Fixed height for card chain blocks and card chain transactions requested.
Changelog
Enhancements
Added fixed height for card chain blocks and transactions.

Checklist for your PR
CHANGELOG.md
with this PRmaster
in theVersion
column.