fetch coin gecko id based on coin symbol #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coin Gecko provides API with all listed coins. We can use this API to find coin id instead of setting it by hand.
Pull Request Test Coverage Report for Build 1a214014-d8f3-41a6-b637-b56f4580fe6a
💛 - Coveralls |
vbaranov
reviewed
Sep 3, 2019
| @@ -18,6 +18,26 @@ defmodule Explorer.ExchangeRates.Source.CoinGeckoTest do | |||
| } | |||
| """ | |||
|
|
|||
| @coins_list """ | |||
There was a problem hiding this comment.
@ayrat555 let's add coins for all chains, that we support, to the tests
There was a problem hiding this comment.
@can you please list their coin symbols defined as COIN in env vars?
There was a problem hiding this comment.
ETH, POA, RBTC, DAI, CLO
There was a problem hiding this comment.
I added tests for all supported chains
pasqu4le
approved these changes
Sep 6, 2019
|
@vbaranov rootstock market cap calculation uses records from db. I think your db was empty that's why it returned 0. on production it should be correc |
vbaranov
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coin Gecko provides API with all listed coins.
We can use this API to find coin id instead of setting
it by hand.
Changelog