add AuRa's empty step reward type #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of producing empty blocks nodes in Aura consensus protocol broadcast an EmptyStep(step, parent_hash) message. https://github.com/paritytech/wiki/blob/master/Aura.md#empty-steps
Pull Request Test Coverage Report for Build e2626d9a-28e7-4ba8-84ec-565506f11c4e
💛 - Coveralls |
saneery
approved these changes
Aug 20, 2019
pasqu4le
approved these changes
Aug 20, 2019
|
I'll try it today and give feedback If the errors still occur |
|
Looks good! No error occurs anymore :) Thanks! This also more than halves the CPU/Network usage because the "erroring" Block now must not be retried |
vbaranov
reviewed
Aug 21, 2019
| @@ -182,4 +182,5 @@ defmodule EthereumJSONRPC.Parity.FetchedBeneficiaries do | |||
| defp get_address_type(reward_type, index) when reward_type == "external" and index == 10, do: :validator | |||
| defp get_address_type(reward_type, _index) when reward_type == "block", do: :validator | |||
| defp get_address_type(reward_type, _index) when reward_type == "uncle", do: :uncle | |||
| defp get_address_type(reward_type, _index) when reward_type == "emptyStep", do: :validator | |||
vbaranov
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of producing empty blocks nodes in Aura consensus protocol
broadcast an EmptyStep(step, parent_hash) message.
https://github.com/paritytech/wiki/blob/master/Aura.md#empty-steps
resolves #2347
Changelog