Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process new metadata format for whisper #2592

Merged
merged 4 commits into from
Aug 21, 2019

Conversation

ayrat555
Copy link
Contributor

fixes #2584

Solidity >= 0.5.11 has new whisper metadata format
Metadata: Update the swarm hash to the current specification,
changes bzzr0 to bzzr1 and urls to use bzz-raw://

https://github.com/ethereum/solidity/blob/develop/Changelog.md#0511-2019-08-12

Changelog

  • process new metadata format for whisper

Solidity >= 0.5.11 has new whisper metadata format
Metadata: Update the swarm hash to the current specification,
changes bzzr0 to bzzr1 and urls to use bzz-raw://

https://github.com/ethereum/solidity/blob/develop/Changelog.md#0511-2019-08-12
@coveralls
Copy link

coveralls commented Aug 19, 2019

Pull Request Test Coverage Report for Build 694d4f4f-9676-4c7d-9e22-32d7c2080c62

  • 1 of 3 (33.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 79.072%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/smart_contract/verifier/constructor_arguments.ex 0 2 0.0%
Totals Coverage Status
Change from base Build 0978d318-74bd-414a-8d12-2434e16ef351: 0.1%
Covered Lines: 5199
Relevant Lines: 6575

💛 - Coveralls

In the PR (#2566) phoenix
was updated to `1.4.9`. But apparently new changes cause web socket
connection to disconnect and connect again which shows `Connection
Closed` message. We should investigate this issue and update phoenix
framework after that - #2595
@vbaranov vbaranov merged commit 55dc106 into master Aug 21, 2019
@vbaranov vbaranov deleted the ab-add-new-whisper-metadata-format branch August 21, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contract verification failed when using compiler v0.5.11+commit.c082d0b4
5 participants