Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Need recompile" column in the env vars table #2577

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Aug 15, 2019

Motivation

Some ENV vars used on the compilation time. We need to distinguish them from others.

Changelog

Need recompile column is added to the table with ENV vars.

The current list of vars that used in the compilation:
DISABLE_WEBAPP
DISABLE_READ_API
DISABLE_WRITE_API
DISABLE_INDEXER
GRAPHIQL_TRANSACTION

Checklist for your PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build ab3cc03e-f980-4b22-a1c6-f9c404115d94

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 79.123%

Files with Coverage Reduction New Missed Lines %
apps/explorer/lib/explorer/chain/cache/transaction_count.ex 2 84.21%
Totals Coverage Status
Change from base Build 17850602-df8e-435c-80cf-20128ccea7eb: -0.03%
Covered Lines: 5196
Relevant Lines: 6567

💛 - Coveralls

@vbaranov vbaranov changed the title Need recompile column in the env vars table "Need recompile" column in the env vars table Aug 15, 2019
@vbaranov vbaranov merged commit 0c72e12 into master Aug 27, 2019
@vbaranov vbaranov deleted the vb-env-vars-update branch August 27, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants