Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network icons preload #2570

Merged
merged 2 commits into from
Aug 15, 2019
Merged

Network icons preload #2570

merged 2 commits into from
Aug 15, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Aug 14, 2019

Motivation

Network icons load every time when a user opens the network menu causing for a while:
Screenshot 2019-08-14 at 19 06 46

Changelog

Enhancements

Preload of network icons added with this PR

Checklist for your PR

@vbaranov vbaranov force-pushed the vb-network-icons-preload branch from a6f00b6 to c1fb217 Compare August 14, 2019 16:10
@vbaranov vbaranov self-assigned this Aug 14, 2019
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Aug 14, 2019
@vbaranov vbaranov requested review from saneery, pasqu4le, ayrat555 and Heimdell and removed request for saneery August 14, 2019 16:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build e6051c43-adb2-49e3-a050-8a4cfe3e33da

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 79.171%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 1 78.57%
Totals Coverage Status
Change from base Build 40ef733c-0c96-4391-964b-9a12e1e93cb8: -0.02%
Covered Lines: 5158
Relevant Lines: 6515

💛 - Coveralls

@vbaranov vbaranov merged commit ec25acf into master Aug 15, 2019
@vbaranov vbaranov deleted the vb-network-icons-preload branch August 15, 2019 09:58
@vbaranov vbaranov mentioned this pull request Nov 7, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants