Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Totally? fix dark theme #2524

Merged
merged 8 commits into from
Aug 9, 2019
Merged

Conversation

maxgrapps
Copy link
Contributor

Issue - #2451 (2 issues about validators data)
Screen Shot 2019-08-07 at 22 20 30
Screen Shot 2019-08-07 at 22 20 45

@maxgrapps maxgrapps changed the title Dark theme ui issues Fix dark theme validator data styles Aug 7, 2019
@maxgrapps maxgrapps requested a review from vbaranov August 7, 2019 19:28
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pashagonchar is this intentional that buttons in the day mode have different colours?

Screenshot 2019-08-08 at 12 50 17

@pashagonchar
Copy link

pashagonchar commented Aug 8, 2019

@pashagonchar is this intentional that buttons in the day mode have different colours?

Screenshot 2019-08-08 at 12 50 17

buttons should be the same

@vbaranov
Copy link
Member

vbaranov commented Aug 8, 2019

@maxgrapps

is this intentional that buttons in the day mode have different colours?

it is a bug (see comment above). Please fix it.

@vbaranov
Copy link
Member

vbaranov commented Aug 8, 2019

@maxgrapps

Also regarding to dark mode I guess we should fix this alert too:

Screenshot 2019-08-08 at 17 09 08

stg: /tx/0x33ee933dc7b0cc7545f3d1d5d5f1db263c951af6773fff7fd82fe8de2e87d777/internal_transactions

@maxgrapps
Copy link
Contributor Author

@vbaranov fixed alert background and address button color for default theme
Screen Shot 2019-08-08 at 20 12 24
Screen Shot 2019-08-08 at 20 02 45

@vbaranov vbaranov self-requested a review August 9, 2019 08:52
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxgrapps error became green now

Screenshot 2019-08-09 at 11 51 41

@vbaranov
Copy link
Member

vbaranov commented Aug 9, 2019

@maxgrapps

/tx/0xf83d3fb24b53e2925a40864808d637510ea4a532decc98afb076d7f5893edcc4/logs

Screenshot 2019-08-09 at 11 59 30

v.s.

Screenshot 2019-08-09 at 11 58 58

There is no box for a note in the dark mode

@vbaranov
Copy link
Member

vbaranov commented Aug 9, 2019

Verify button is invisible

/address/0xb363a3c584b1f379c79fbf09df015da5529d4dac/contract_verifications/new

Screenshot 2019-08-09 at 12 02 09

@vbaranov
Copy link
Member

vbaranov commented Aug 9, 2019

Screenshot 2019-08-09 at 12 17 35

@vbaranov
Copy link
Member

vbaranov commented Aug 9, 2019

/address/0x61edcdf5bb737adffe5043706e7c5bb1f1a56eea/contracts

Screenshot 2019-08-09 at 12 25 04

@vbaranov vbaranov changed the title Fix dark theme validator data styles Totally? fix dark theme Aug 9, 2019
@vbaranov
Copy link
Member

vbaranov commented Aug 9, 2019

@maxgrapps

What does prevent to implement dark mode for

Screenshot 2019-08-09 at 12 56 26

if we did it for

Screenshot 2019-08-09 at 12 56 20

@vbaranov
Copy link
Member

vbaranov commented Aug 9, 2019

@maxgrapps could we customize a scroll for dark theme Screenshot 2019-08-09 at 13 07 12?

@maxgrapps
Copy link
Contributor Author

@vbaranov added new bunch of updates for buttons, alerts and 'verify other explorers' dialog

@maxgrapps maxgrapps requested a review from vbaranov August 9, 2019 18:12
@maxgrapps
Copy link
Contributor Author

@maxgrapps could we customize a scroll for dark theme Screenshot 2019-08-09 at 13 07 12?

@vbaranov only way is to add custom scrollbar plugin, but does it better than common scrollbar (I mean how it works, not how it looks)

@vbaranov vbaranov merged commit bcaeb91 into blockscout:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants