Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate autocompletion library influence to page loading performance #2503

Merged
merged 7 commits into from
Aug 6, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Aug 5, 2019

A part of #2390

Motivation

awesomplete js/css assets load synchronously contributing to page loading time. In addition, they are loaded from a 3d-party Github Repo directly.

Changelog

Enhancements

  • the latest 1.1.2 version of awesomplete utility installed as a regular npm dependency.

Update: awesomplete package downgraded to 1.1.2 1fb6fa5 because of this issue LeaVerou/awesomplete#17193

  • awesomplete-util.js copied to ./js/lib and cleared out with ES linter
  • awesomplete.css loading is changed to async loading since autocompletion is not a part of critical css.

Advantages

  • decreasing of every page loading time (➖ 300ms)
  • independency of 3d-party Github repo

Chore

  • the last versions of css-loader and sass-loader deps are installed

Checklist for your PR

@vbaranov vbaranov mentioned this pull request Aug 5, 2019
5 tasks
@vbaranov vbaranov self-assigned this Aug 5, 2019
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Aug 5, 2019
@coveralls
Copy link

coveralls commented Aug 5, 2019

Pull Request Test Coverage Report for Build 15116cbc-d74e-454b-a756-1caa93ad2d98

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.291%

Totals Coverage Status
Change from base Build 1806de47-e9a9-4846-8359-5e17fec6f30e: 0.0%
Covered Lines: 5165
Relevant Lines: 6514

💛 - Coveralls

@vbaranov vbaranov added do not merge wip and removed ready for review This PR is ready for reviews. labels Aug 6, 2019
@vbaranov vbaranov added ready for review This PR is ready for reviews. and removed do not merge wip labels Aug 6, 2019
@vbaranov vbaranov merged commit 782584c into master Aug 6, 2019
@vbaranov vbaranov deleted the npm-packages-update branch August 6, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants