Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove parentheses in market cap percentage #2418

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Remove parentheses in market cap percentage #2418

merged 1 commit into from
Jul 24, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Jul 23, 2019 •
edited
Loading

Motivation

Parentheses in % of market cap look redundant in ./accounts page

Before
Screenshot 2019-07-23 at 18 05 06

After
Screenshot 2019-07-23 at 18 03 03

Changelog

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@vbaranov vbaranov changed the title Remove brackets Remove parentheses in market cap percentage Jul 23, 2019
@vbaranov vbaranov force-pushed the vb-remove-brackets branch from e5e903f to 80587f8 Compare July 23, 2019 15:14
@vbaranov vbaranov self-assigned this Jul 23, 2019
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label Jul 23, 2019
@coveralls
Copy link

coveralls commented Jul 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 886bfcd5-b0b3-416f-a0f8-6d0295f3a6d1

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 79.521%
Totals Coverage Status
Change from base Build b452ec74-8980-4912-bae2-d3cf01f6c4fb: 0.2%
Covered Lines: 5145
Relevant Lines: 6470
💛 - Coveralls

@vbaranov vbaranov merged commit 79e6650 into master Jul 24, 2019
@vbaranov vbaranov deleted the vb-remove-brackets branch July 24, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayrat555 ayrat555 ayrat555 approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le Awaiting requested review from pasqu4le

@Heimdell Heimdell Awaiting requested review from Heimdell

Assignees

@vbaranov vbaranov

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vbaranov @coveralls @ayrat555 @saneery