Controllers Improvements #2391
Merged
Controllers Improvements #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasqu4le
force-pushed
the
pp-improve-controllers
branch
from
63b3e4b to
cb0a06d
Compare
Pull Request Test Coverage Report for Build 99ac9c93-55e6-480d-a66e-101d03c86a7a
💛 - Coveralls |
Problem: a lot of function take an entity as an parameter, but only use its hash/id. This makes tracing the necessary scope of functions harder and is one of the cause for unnecessary queries/code execution. Solution: refactor these functions to take only a hash (or an id).
Problem: some controller retrieves entire entities from the database when it only needs to check their existence. Solution: provide Exploerer.Chain functions to check for existence and use them where possible.
pasqu4le
force-pushed
the
pp-improve-controllers
branch
from
cb0a06d to
4a46e6e
Compare
pasqu4le
added
ready for review
ayrat555
approved these changes
Jul 22, 2019
saneery
approved these changes
Jul 22, 2019
| @spec query_verified_contract(Hash.Address.t(), functions()) :: functions_results() | ||
| def query_verified_contract(address_hash, functions) do | ||
| @spec query_verified_contract(Hash.Address.t(), functions(), SmartContract.abi() | nil) :: functions_results() | ||
| def query_verified_contract(address_hash, functions, mabi \\ nil) do |
There was a problem hiding this comment.
Oh I gave it that name for maybe abi (because it can be nil) so that a few lines down the code is abi = ...
|
@vbaranov sure. The first commit should have the biggest impact among the 3, pages affected are:
The second commit does not directly affect performances, but was necessary for the following one. The third commit has a smaller impact, on these pages:
|
vbaranov
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
after #2111, #2249, #2216 and #2305 a few remaining controllers still have not been checked for possible improvements.
This PR is the result of going trough all these controllers.
Changelog
There are 3 separate commits:
Explorer.Chainfunctions to only take an hash/id where possible, just like it was done for AddressesExploerer.Chainto only check for the existence of an entityChecklist for your PR
CHANGELOG.mdwith this PR