-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decode constructor arguments for verified smart contracts #2374
Conversation
Pull Request Test Coverage Report for Build 62438599-ecf2-49f9-b092-626d6ba18bec
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://etherscan.io/address/0x3fef7546fecf188c56080dcc5c4bb3dd7b20ff6a#code shows 12 arguments. The same contract on stg - 10
Just for the record:
I should revoke my previous review. Seems, the number and order of parameters are correct in Blockscout. I think what Etherscan is doing wrong, that it shows the number of arguments or/and offset as a separate parameter(s). Moreover, the order of parameters is wrong there. It would be awesome if we could add additional features:
|
@vbaranov done |
@ayrat555 please resolve merging conflicts |
@vbaranov done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding
highlighting of the external library name with a terracotta colour
Please make it the same style as in verified source code:
Instead of style="color:#e2725b;"
use class="hljs-title"
@vbaranov style is fixed |
with #2368 fixes #2320
Changelog