Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode constructor arguments for verified smart contracts #2374

Merged
merged 13 commits into from
Jul 23, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jul 17, 2019

img
with #2368 fixes #2320

Changelog

  • decode constructor arguments for verified smart contracts

@coveralls
Copy link

coveralls commented Jul 17, 2019

Pull Request Test Coverage Report for Build 62438599-ecf2-49f9-b092-626d6ba18bec

  • 0 of 15 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 80.754%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/address_contract_view.ex 0 15 0.0%
Totals Coverage Status
Change from base Build e8dae500-635c-4255-b6c3-0243d5e67b8e: -0.2%
Covered Lines: 5203
Relevant Lines: 6443

💛 - Coveralls

vbaranov added a commit that referenced this pull request Jul 17, 2019
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://etherscan.io/address/0x3fef7546fecf188c56080dcc5c4bb3dd7b20ff6a#code shows 12 arguments. The same contract on stg - 10

@vbaranov vbaranov self-requested a review July 18, 2019 08:14
@vbaranov
Copy link
Member

Just for the record:

https://etherscan.io/address/0x3fef7546fecf188c56080dcc5c4bb3dd7b20ff6a#code shows 12 arguments. The same contract on stg - 10

I should revoke my previous review. Seems, the number and order of parameters are correct in Blockscout. I think what Etherscan is doing wrong, that it shows the number of arguments or/and offset as a separate parameter(s). Moreover, the order of parameters is wrong there.

It would be awesome if we could add additional features:

  • show the type of parameter kinda Arg [0] (string) : 546965722031
  • highlighting of the type with the bold font
  • highlighting of the external library name with a terracotta colour

@ayrat555
Copy link
Contributor Author

@vbaranov done

@vbaranov
Copy link
Member

@ayrat555 please resolve merging conflicts

@ayrat555
Copy link
Contributor Author

@vbaranov done

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555

Regarding

highlighting of the external library name with a terracotta colour

Please make it the same style as in verified source code:
Instead of style="color:#e2725b;" use class="hljs-title"

@ayrat555
Copy link
Contributor Author

@vbaranov style is fixed

@vbaranov vbaranov self-requested a review July 23, 2019 09:52
@vbaranov vbaranov merged commit 30f7fa3 into master Jul 23, 2019
@vbaranov vbaranov deleted the ab-decode-constructor-arguments branch July 23, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verified contract view improvements
5 participants