Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase threshold for scientific notation #2278

Merged
merged 4 commits into from
Jul 2, 2019
Merged

increase threshold for scientific notation #2278

merged 4 commits into from
Jul 2, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jul 2, 2019

resolves #2274

Changelog

  • increase threshold for scientific notation

@ayrat555 ayrat555 requested review from vbaranov, pasqu4le and saneery July 2, 2019 08:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 85668035-4bb8-4bca-a69c-94e503a76081

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 80.98%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/channels/exchange_rate_channel.ex 1 50.0%
apps/explorer/lib/explorer/market/market_history_cache.ex 3 83.33%
Totals Coverage Status
Change from base Build 6eefae68-17ed-4aaf-b0d2-674ca67f5774: -0.06%
Covered Lines: 5105
Relevant Lines: 6304
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build c2e51d84-edf1-4a4b-8d19-3bdd24a7be8e

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 81.218%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/block/fetcher.ex 1 92.0%
apps/indexer/lib/indexer/fetcher/coin_balance.ex 1 92.31%
apps/indexer/lib/indexer/block/fetcher/receipts.ex 1 75.0%
Totals Coverage Status
Change from base Build 7884743a-2047-49f5-8746-b5eae4656145: 0.1%
Covered Lines: 5120
Relevant Lines: 6304
💛 - Coveralls

vbaranov
vbaranov approved these changes Jul 2, 2019
View reviewed changes
CHANGELOG.md Outdated
@@ -64,6 +64,7 @@
- [#2248](https://github.com/poanetwork/blockscout/pull/2248) - sort block after query execution for average block time
- [#2270](https://github.com/poanetwork/blockscout/pull/2270) - Remove duplicate params in `Indexer.Fetcher.TokenBalance`
- [#2268](https://github.com/poanetwork/blockscout/pull/2268) - remove not existing assigns in html code
- [#2278](https://github.com/poanetwork/blockscout/pull/2278) - increase threshold for scientific notation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 to the top? 😃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@vbaranov vbaranov merged commit e22f83e into master Jul 2, 2019
@vbaranov vbaranov deleted the ab-increase-decimal-for-exp-notation branch July 2, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le Awaiting requested review from pasqu4le

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase threshold value for numbers in scientific notation
4 participants
@ayrat555 @coveralls @vbaranov @saneery