Remove duplicate params in Indexer.Fetcher.TokenBalance
#2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: `Explorer.Chain.Import.Runner.Address.TokenBalances` fails with the `cardinality_violation` error because it tries to insert more than once token balances (for the same {token_contract_address_hash, address_hash, block_number} tuple) in a single database transaction.
Solution: filter out duplicate parameters in `Indexer.Fetcher.TokenBalance` so that no duplicates are sent to be imported.
pasqu4le
force-pushed
the
pp-dedup-params-in-token_balance-fetcher
branch
from
cd40eb2 to
144f39d
Compare
Pull Request Test Coverage Report for Build f4d1f5d1-ae59-4b42-bf87-0c78e3aa06e4
💛 - Coveralls |
ayrat555
approved these changes
Jul 1, 2019
saneery
approved these changes
Jul 1, 2019
vbaranov
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Explorer.Chain.Import.Runner.Address.TokenBalancesfails with thecardinality_violationerror because it tries to insert more than once token balances (for the same {token_contract_address_hash, address_hash, block_number} tuple) in a single database transaction.Changelog
Bug Fixes
This PR filters out duplicate parameters in
Indexer.Fetcher.TokenBalanceso that no duplicates are sent to be imported.Checklist for your PR
CHANGELOG.mdwith this PR