Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce BlocksTransactionsMismatch memory footprint #2258

Merged
merged 3 commits into from
Jul 3, 2019

Conversation

pasqu4le
Copy link
Contributor

closes #2234

Changelog

Enhancements

This PR reduces the memory footprint of the BlocksTransactionsMismatch temporary fetcher by requesting only the block hash instead of the whole block.

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@pasqu4le pasqu4le added the ready for review This PR is ready for reviews. label Jun 27, 2019
@pasqu4le pasqu4le self-assigned this Jun 27, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 07390a12-adea-459b-835c-78d93fd99c5b

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.1%) to 80.991%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/indexer/lib/indexer/temporary/blocks_transactions_mismatch.ex 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/channels/exchange_rate_channel.ex 1 50.0%
apps/indexer/lib/indexer/fetcher/token.ex 1 78.57%
apps/indexer/lib/indexer/fetcher/internal_transaction.ex 2 58.62%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.1%
apps/indexer/lib/indexer/block/fetcher.ex 3 88.0%
Totals Coverage Status
Change from base Build f7af39be-7886-42ee-a941-114a4933d42c: -0.1%
Covered Lines: 5036
Relevant Lines: 6218

💛 - Coveralls

vbaranov added a commit that referenced this pull request Jul 2, 2019
@vbaranov vbaranov merged commit 4bbfe20 into master Jul 3, 2019
@vbaranov vbaranov deleted the reduce-blocktransactionsmismatch-memory-footprint branch July 3, 2019 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

block_transactions_mismatch repeatedly in logs
5 participants