Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'download csv' button added to different tabs #2257

Merged
merged 3 commits into from
Jun 27, 2019
Merged

'download csv' button added to different tabs #2257

merged 3 commits into from
Jun 27, 2019

Conversation

maxgrapps
Copy link
Contributor

Added html/css for 'download csv' button to:

  1. address_transaction/index.html.eex
  2. address_token/index.html.eex
  3. address_internal_transaction/index.html.eex
  4. tokens/transfer/index.html.eex

but you need to add correct href for this buttons

@ayrat555
Copy link
Contributor

it's not implemented for all these pages

@vbaranov
Copy link
Member

@ayrat555 where does the logic exist for buttons in 1 - 4?
@maxgrapps let's comment buttons appearance everywhere except where the logic for buttons exists

@ayrat555
Copy link
Contributor

@vbaranov 1 and 2

@vbaranov
Copy link
Member

@maxgrapps

Please hide buttons for

3. address_internal_transaction/index.html.eex
4. tokens/transfer/index.html.eex

since there is no logic for those cases yet. We will uncomment when the logic will be delivered

@maxgrapps
Copy link
Contributor Author

@vbaranov okay, done

@vbaranov vbaranov merged commit 10be3b1 into blockscout:ab-token-transfer-csv-export Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants