-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More transaction controllers improvements #2249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build e0951e66-f170-4ac3-84fb-528f76ebdb70
💛 - Coveralls |
1c627a9
to
cccbf12
Compare
vbaranov
approved these changes
Jul 3, 2019
ayrat555
approved these changes
Jul 3, 2019
pasqu4le
added a commit
that referenced
this pull request
Jul 19, 2019
pasqu4le
added a commit
that referenced
this pull request
Jul 19, 2019
pasqu4le
added a commit
that referenced
this pull request
Jul 19, 2019
vbaranov
pushed a commit
that referenced
this pull request
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
All the transactions-related controllers that were not considered by #2111 have been analyzed for potential improvements. Complete list:
TransactionController
TransactionInternalTransactionController
TransactionLogController
TransactionRawTraceController
TransactionTokenTransferController
RecentTransactionsController
PendingTransactionController
BlockTransactionController
API.RPC.TransactionController
Changelog
Enhancements
These are the changes produced after going over the above list of controllers:
order_by
inExplorer.Chain.recent_collated_transactions
has been removed because it is already included infetch_transactions
TransactionController.show
has been refactored to use thewith
syntax, just like most othersExplorer.Chain.hash_to_transaction
now builds a query fromTransaction
instead offetch_transactions
, because the latter has an ordering that is not usefulExplorer.Chain.transaction_has_token_transfers
has been changed to useRepo.exists?
TransactionRawTraceController.index
has been simplified by removing a list of association used inChain.transaction_to_internal_transactions
that was not necessaryExplorer.Chain.transaction_to_internal_transactions
has also been modified to not preloadtransaction: :block
by default, because the controller above does not need itBlockTransactionController.index
's association list forChain.block_to_transactions
,:block
has been madeoptional
, because usingrequired
adds a duplicate inner join to the queryChecklist for your PR
CHANGELOG.md
with this PR