Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save and show additional validation fields to smart contract #2235

Merged
merged 13 commits into from
Jul 1, 2019
Merged

save and show additional validation fields to smart contract #2235

merged 13 commits into from
Jul 1, 2019

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Jun 25, 2019 •
edited
Loading

img

fixes #2226

@coveralls
Copy link

coveralls commented Jun 25, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2fa8227c-75b0-4cc7-93c4-073202965c1c

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 81.138%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/controllers/address_contract_verification_controller.ex 2 66.67%
Totals Coverage Status
Change from base Build dbc300c4-e486-441e-ad9b-f378ec7fea2c: -0.007%
Covered Lines: 5119
Relevant Lines: 6309
💛 - Coveralls

@ayrat555 ayrat555 force-pushed the ab-add-new-fields-for-contract-verification branch from 2b21a70 to 6f79e7e Compare June 25, 2019 12:38
vbaranov
vbaranov reviewed Jun 27, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 will it work only for newly verified contracts after implementation of this fix?

@ayrat555
Copy link
Contributor Author

@vbaranov yes

@vbaranov vbaranov self-requested a review June 28, 2019 11:38
@vbaranov
Copy link
Member

vbaranov commented Jul 1, 2019

@ayrat555 please fix merging conflicts

@ayrat555
Copy link
Contributor Author

ayrat555 commented Jul 1, 2019

@vbaranov done

@vbaranov vbaranov merged commit fe47614 into master Jul 1, 2019
@vbaranov vbaranov deleted the ab-add-new-fields-for-contract-verification branch July 1, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

@Heimdell Heimdell Awaiting requested review from Heimdell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

save and show additional contract params
5 participants
@ayrat555 @coveralls @vbaranov @saneery @pasqu4le