add rsk format of checksum #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6e47786f-6226-48de-a452-0361d8dc91dc
💛 - Coveralls |
saneery
approved these changes
Jun 12, 2019
zachdaniel
approved these changes
Jun 12, 2019
vbaranov
reviewed
Jun 13, 2019
apps/explorer/config/config.exs
Outdated
| @@ -80,7 +80,9 @@ if System.get_env("SOURCE_MODULE") == "TransactionAndLog" do | |||
| end | |||
|
|
|||
| config :explorer, | |||
| solc_bin_api_url: "https://solc-bin.ethereum.org" | |||
| solc_bin_api_url: "https://solc-bin.ethereum.org", | |||
| chain_id: System.get_env("CHAIN_ID"), | |||
There was a problem hiding this comment.
@ayrat555 Do we need to define a CHAIN_ID var since we can get chain ID from the Ethereum client https://github.com/ethereum/wiki/wiki/JSON-RPC#net_version?
There was a problem hiding this comment.
@vbaranov you're right. I'll update my pr
vbaranov
approved these changes
Jun 16, 2019
| else | ||
| to_string(["0x" | checksum_formatted]) | ||
| end | ||
| def rsk_checksum(hash) do |
There was a problem hiding this comment.
@ayrat555 let's add a comment here with the link to the corresponding RSKIP
pasqu4le
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2139
We should add one env variable:
CHECKSUM_FUNCTION=rskChangelog