Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes issues, ui issues #2110

Merged
merged 7 commits into from
Jun 6, 2019
Merged

Themes issues, ui issues #2110

merged 7 commits into from
Jun 6, 2019

Conversation

maxgrapps
Copy link
Contributor

@maxgrapps maxgrapps commented Jun 6, 2019

  1. Colors issues and suggestions for all themes. Thats how they look like now:
  • blockscout, poa
    blockscout
  • rsk
    rsk
  • etc
    etc
  • eth
    eth
  • xdai
    xdai
  • sokol
    sokol
  • kovan
    kovan
  • ropsten
    ropsten
  • goerli
    goerli
  • rinkeby
    rinkeby
  1. Added shadow for statistics block
    Screen Shot 2019-06-06 at 17 05 00

  2. Changes transition for buttons, dropdowns, tabs, etc

  3. Logs search size increased, added logic for hiding pagination, font-weight issue for input
    (Please, review apps/block_scout_web/lib/block_scout_web/templates/common_components/_pagination_container.html.eex . Is it correct? I am added 'disabled' for all pagination container)
    Screen Shot 2019-06-06 at 17 06 28
    Can we hide search if theres no logs also?

  4. Increased margin between dropdown and textarea
    Screen Shot 2019-06-06 at 17 08 01

  5. Added current styles for heading and copy button in 'code' tab
    Screen Shot 2019-06-06 at 12 50 11

  6. Network list aligned to the right
    Screen Shot 2019-06-06 at 17 10 04

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

background-color: $btn-dropdown-line-color;
border-color: $btn-dropdown-line-color;
background-color: #f5f6fa;
border-color: #f5f6fa;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use var for this repeated colour?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbaranov resolved

@vbaranov
Copy link
Member

vbaranov commented Jun 6, 2019

@maxgrapps fix eslint test:
./node_modules/.bin/eslint --fix from block_scout_web app

@maxgrapps
Copy link
Contributor Author

@vbaranov seems, it's okay now

@vbaranov vbaranov merged commit bbd0f44 into blockscout:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants