Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown styles, tooltip gap fix, page 404 added #2082

Merged
merged 10 commits into from
Jun 3, 2019
Merged

Dropdown styles, tooltip gap fix, page 404 added #2082

merged 10 commits into from
Jun 3, 2019

Conversation

maxgrapps
Copy link
Contributor

@maxgrapps maxgrapps commented Jun 2, 2019

Dropdown
was:
Screen Shot 2019-06-03 at 01 47 12
now:
Screen Shot 2019-06-03 at 01 56 14

Tooltip
was:
Screen Shot 2019-06-03 at 01 56 44
now:
Screen Shot 2019-06-03 at 02 22 05

Page 404
poa_404

Template for 404 was added to apps/block_scout_web/lib/block_scout_web/templates/page_not_found/index.html.eex

NOTE: This pages made for poa or blockscout theme. Only difference for another themes is in images. I uploaded all images to images/errors-img

@pashagonchar
Copy link

@maxgrapps Make more space between button and tooltip, like 20-30 px

@pashagonchar
Copy link

@maxgrapps how looks other dropdown lists, for example in menu?

@maxgrapps maxgrapps changed the title Dropdown styles, tooltip gap fix Dropdown styles, tooltip gap fix, page 404 added Jun 3, 2019
@maxgrapps
Copy link
Contributor Author

@vbaranov added 404 page (read description)

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the record: we need a missing logic to show this 404 page.

@vbaranov vbaranov merged commit 07abad7 into blockscout:master Jun 3, 2019
@vbaranov vbaranov mentioned this pull request Jun 7, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants