Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fields to tx apis, small cleanups #2064

Merged
merged 2 commits into from
Jun 3, 2019

Conversation

zachdaniel
Copy link
Contributor

@zachdaniel zachdaniel commented May 29, 2019

#1862

Changelog

Enhancements

  • Add logIndex to the tokentx action in the account module

  • Add transactionHash and index to the txlistinternal action in the account module

  • Clean up some unused variables/aliases in test.

  • Remove a log that was emitted unnecessarily and often in tests.

    • I added an entry to CHANGELOG.md with this PR
    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
    • I checked whether I should update the docs and did so if necessary

@zachdaniel zachdaniel force-pushed the add-tx-identifier-fields-to-api branch 2 times, most recently from 3cfbcda to 911ed36 Compare May 29, 2019 20:43
@coveralls
Copy link

coveralls commented May 29, 2019

Pull Request Test Coverage Report for Build ac935497-f755-4a7d-beae-ef226d8b6ef9

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 80.776%

Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/channels/exchange_rate_channel.ex 1 50.0%
Totals Coverage Status
Change from base Build 08ec87f4-ee92-4ee3-ab52-07733d932cdb: -0.01%
Covered Lines: 4811
Relevant Lines: 5956

💛 - Coveralls

@zachdaniel zachdaniel force-pushed the add-tx-identifier-fields-to-api branch 2 times, most recently from f339fa5 to 6518518 Compare May 30, 2019 14:44
@zachdaniel zachdaniel force-pushed the add-tx-identifier-fields-to-api branch from 6518518 to 9ea62f0 Compare May 30, 2019 14:56
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/api?module=account&action=txlistinternal&address=0x1B3858E01CCE5d0491f3c96A9996a65607f3493b&offset=10

returns me 504 error, but I doubt it is because of changes from this PR. It returns 504 in prod as well.

@zachdaniel
Copy link
Contributor Author

I can look into the performance of this endpoint for addresses with many transactions.

@vbaranov
Copy link
Member

@zachdaniel

I can look into the performance of this endpoint for addresses with many transactions.

It would be awesome

@vbaranov vbaranov merged commit 95d9041 into master Jun 3, 2019
@vbaranov vbaranov deleted the add-tx-identifier-fields-to-api branch June 3, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants