Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow bytes32 for name and symbol #2052

Merged
merged 5 commits into from
May 30, 2019
Merged

allow bytes32 for name and symbol #2052

merged 5 commits into from
May 30, 2019

Conversation

ayrat555
Copy link
Contributor

We weren't setting name and symbol for some tokens because we were assuming they all have a string type

Changelog

  • allow bytes32 for name and symbol

@coveralls
Copy link

coveralls commented May 29, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build ed93585f-2057-489b-b12d-895aa880889b

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 80.843%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/block/fetcher.ex 1 87.84%
apps/indexer/lib/indexer/block/catchup/fetcher.ex 7 69.23%
Totals Coverage Status
Change from base Build 101a5230-5ecf-4dda-8ca4-e8f8e94aebb6: -0.1%
Covered Lines: 4773
Relevant Lines: 5904
💛 - Coveralls

@vbaranov vbaranov merged commit 9c929ee into master May 30, 2019
@vbaranov vbaranov deleted the ab-fix-abi-for-token-name branch May 30, 2019 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

@saneery saneery Awaiting requested review from saneery

@pasqu4le pasqu4le Awaiting requested review from pasqu4le

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayrat555 @coveralls @vbaranov @zachdaniel