-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verification links to other explorers #2040
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fy-link-to-other-explorers
Verify link to other explorers blocks and modal dialog
…k/blockscout into verify-link-to-other-explorers
Pull Request Test Coverage Report for Build 8e70d631-3d29-4b38-b0a5-889ee0a7a7de
💛 - Coveralls |
ayrat555
approved these changes
May 28, 2019
saneery
approved these changes
May 28, 2019
pasqu4le
approved these changes
May 28, 2019
zachdaniel
approved these changes
May 28, 2019
Fixed modal dialog width for 'verify other explorers'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived from #1890
Motivation
As we should add verification in other explorers links to multiple chains, we need to keep this mockup in the master branch.
CHANGELOG
Updates relatively parent PR:
to
address)https://github.com/poanetwork/blockscout/blob/164d687201f0789e555c7ccc23e0116a6076bc1f/apps/block_scout_web/lib/block_scout_web/templates/transaction/overview.html.eex#L53-L54
https://github.com/poanetwork/blockscout/blob/164d687201f0789e555c7ccc23e0116a6076bc1f/apps/block_scout_web/lib/block_scout_web/templates/address/overview.html.eex#L123-L124
Checklist for your PR
CHANGELOG.md
with this PR