Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification links to other explorers #2040

Merged
merged 37 commits into from
May 28, 2019
Merged

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented May 27, 2019

Derived from #1890

Screenshot 2019-05-27 at 20 00 36
Screenshot 2019-05-27 at 20 00 44

Motivation

As we should add verification in other explorers links to multiple chains, we need to keep this mockup in the master branch.

CHANGELOG

Updates relatively parent PR:

  • link in the tx should lead to tx in another explorer (not to tx to address)
  • links should be available for all txs/addresses (not only related to contracts)
  • verification links are switched off in master by default

https://github.com/poanetwork/blockscout/blob/164d687201f0789e555c7ccc23e0116a6076bc1f/apps/block_scout_web/lib/block_scout_web/templates/transaction/overview.html.eex#L53-L54

https://github.com/poanetwork/blockscout/blob/164d687201f0789e555c7ccc23e0116a6076bc1f/apps/block_scout_web/lib/block_scout_web/templates/address/overview.html.eex#L123-L124

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@vbaranov vbaranov requested review from ayrat555 and saneery and removed request for ayrat555 May 27, 2019 16:59
@coveralls
Copy link

coveralls commented May 27, 2019

Pull Request Test Coverage Report for Build 8e70d631-3d29-4b38-b0a5-889ee0a7a7de

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 80.799%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/block_scout_web/lib/block_scout_web/views/address_view.ex 0 5 0.0%
Totals Coverage Status
Change from base Build 86077c4c-c7d0-48e5-83f1-f08302c14a43: -0.07%
Covered Lines: 4755
Relevant Lines: 5885

💛 - Coveralls

@vbaranov vbaranov changed the title Verify link to other explorers Verification links to other explorers May 27, 2019
@vbaranov vbaranov added the ready for review This PR is ready for reviews. label May 27, 2019
@vbaranov vbaranov merged commit 608485f into master May 28, 2019
@vbaranov vbaranov deleted the verify-link-to-other-explorers branch May 28, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants