Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix to/from filters on tx list pages #2017

Merged
merged 3 commits into from
May 28, 2019
Merged

fix: fix to/from filters on tx list pages #2017

merged 3 commits into from
May 28, 2019

Conversation

zachdaniel
Copy link
Contributor

@zachdaniel zachdaniel commented May 23, 2019 •
edited by vbaranov
Loading

A part of #1938

Changelog

Bug Fixes

  • Make the return type of where_any_address_fields_match/3 consistent, so that it doesn't break the query when :to or :from are passed in.

    • I added an entry to CHANGELOG.md with this PR
    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
    • I checked whether I should update the docs and did so if necessary

@zachdaniel zachdaniel force-pushed the fix-to-from-filters branch from 39b4374 to 6a065bf Compare May 23, 2019 18:39
@coveralls
Copy link

coveralls commented May 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build e4f65bc0-b300-4951-a2a0-380130876a52

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.237%
Totals Coverage Status
Change from base Build ae1c527a-460d-4beb-a514-abe8b88d1fe8: 0.0%
Covered Lines: 4728
Relevant Lines: 5820
💛 - Coveralls

vbaranov pushed a commit that referenced this pull request May 24, 2019
@zachdaniel @vbaranov
#2017
76e6023
@vbaranov vbaranov requested review from vbaranov and ayrat555 May 27, 2019 07:57
vbaranov
vbaranov reviewed May 27, 2019
View reviewed changes
Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zachdaniel

#1938 (comment)

to filter in internal transactions for that address still returns me nothing on stg but it has at least one:
Screenshot 2019-05-27 at 10 58 02

@vbaranov vbaranov merged commit 24b4dfa into master May 28, 2019
@vbaranov vbaranov deleted the fix-to-from-filters branch May 28, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

@ayrat555 ayrat555 Awaiting requested review from ayrat555

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zachdaniel @coveralls @vbaranov @ayrat555 @saneery @pasqu4le