Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addresses page improvements #2009

Merged
merged 5 commits into from
May 24, 2019
Merged

addresses page improvements #2009

merged 5 commits into from
May 24, 2019

Conversation

ayrat555
Copy link
Contributor

Changelog

  • enable prev buttons for addresses page
  • remove JSON parameter when rendering a page
  • hide navigation elements if a page has no items for all pages

@coveralls
Copy link

coveralls commented May 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 6780d994-ad8a-433d-be8c-e12e6c757d57

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 81.065%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/fetcher/token.ex 1 78.57%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.1%
apps/indexer/lib/indexer/block/fetcher.ex 3 87.84%
Totals Coverage Status
Change from base Build 83bce4d0-9ead-4d34-ae50-e7a24bbc9b94: -0.1%
Covered Lines: 4718
Relevant Lines: 5820
💛 - Coveralls

@ayrat555 ayrat555 merged commit 746939b into master May 24, 2019
@ayrat555 ayrat555 deleted the ab-addresse-page-improvements branch May 24, 2019 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov approved these changes

@zachdaniel zachdaniel zachdaniel approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

@saneery saneery Awaiting requested review from saneery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ayrat555 @coveralls @vbaranov @zachdaniel @pasqu4le