Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong parity tasks names in Circle CI #1988

Merged
merged 3 commits into from
May 22, 2019
Merged

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented May 20, 2019

Motivation

Wrong parity tasks names in Circle CI

Changelog

Correct parity tasks names in Circle CI config

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@vbaranov vbaranov added the ready for review This PR is ready for reviews. label May 20, 2019
@coveralls
Copy link

coveralls commented May 20, 2019

Pull Request Test Coverage Report for Build 39ff041a-4cdd-480d-a817-00c188046302

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.106%

Totals Coverage Status
Change from base Build 70545e59-7263-4445-891c-7334f0e4d2a2: 0.0%
Covered Lines: 4709
Relevant Lines: 5806

💛 - Coveralls

@@ -480,7 +480,7 @@ jobs:
command: dockerize -wait tcp://localhost:5432 -timeout 1m

- run:
name: mix test --exclude no_geth
name: mix test --exclude no_parity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure? the test entry is called test_parity_http_websocket

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 I look to the command below. I want to change the name of this command, because mix test --exclude no_geth name confuses, as the command is running with --exclude no_parity flag. How do you suggest to rename?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha. I think we need to rename test_parity_http_websocket entry to test_geth_http_websocket and test_geth_http_websocket to test_parity_http_websocket. Because test_geth_http_websocket runs with no_geth and test_parity_http_websocket runs with no_parity. I think somebody made a mistake here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad

@vbaranov vbaranov merged commit 5c58114 into master May 22, 2019
@vbaranov vbaranov deleted the circle-ci-confg-update branch May 27, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is ready for reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants