-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong parity tasks names in Circle CI #1988
Conversation
Pull Request Test Coverage Report for Build 39ff041a-4cdd-480d-a817-00c188046302
💛 - Coveralls |
@@ -480,7 +480,7 @@ jobs: | |||
command: dockerize -wait tcp://localhost:5432 -timeout 1m | |||
|
|||
- run: | |||
name: mix test --exclude no_geth | |||
name: mix test --exclude no_parity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure? the test entry is called test_parity_http_websocket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayrat555 I look to the command below. I want to change the name of this command, because mix test --exclude no_geth
name confuses, as the command is running with --exclude no_parity
flag. How do you suggest to rename?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha. I think we need to rename test_parity_http_websocket
entry to test_geth_http_websocket
and test_geth_http_websocket
to test_parity_http_websocket
. Because test_geth_http_websocket
runs with no_geth
and test_parity_http_websocket
runs with no_parity
. I think somebody made a mistake here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad
Motivation
Wrong parity tasks names in Circle CI
Changelog
Correct parity tasks names in Circle CI config
CHANGELOG.md
with this PR