Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALLOWED_EVM_VERSIONS env var #1964

Merged
merged 17 commits into from
May 23, 2019
Merged

ALLOWED_EVM_VERSIONS env var #1964

merged 17 commits into from
May 23, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented May 16, 2019 •
edited
Loading

Closes #1918

Changelog

  • ALLOWED_EVM_VERSIONS env var

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@ghost ghost assigned vbaranov May 16, 2019
@ghost ghost added the in progress label May 16, 2019
@coveralls
Copy link

coveralls commented May 16, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build f8aec5ea-7187-4433-9ea2-a90f52e3c669

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.2%) to 81.065%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/fetcher/token.ex 1 78.57%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.1%
apps/indexer/lib/indexer/block/fetcher.ex 3 87.84%
apps/indexer/lib/indexer/block/catchup/fetcher.ex 4 69.23%
Totals Coverage Status
Change from base Build e1890743-7dc0-4de6-8d09-32f15b36c5f0: -0.2%
Covered Lines: 4718
Relevant Lines: 5820
💛 - Coveralls

@vbaranov vbaranov added ready for review This PR is ready for reviews. and removed in progress labels May 16, 2019
@vbaranov vbaranov merged commit c2c5880 into master May 23, 2019
@vbaranov vbaranov deleted the allowed-evm-versions branch May 23, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

@ayrat555 ayrat555 ayrat555 approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

Assignees

@vbaranov vbaranov

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define the list of EVM versions via ENV var
6 participants
@vbaranov @coveralls @zachdaniel @ayrat555 @saneery @pasqu4le