Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default value for release link env var #1958

Merged
merged 5 commits into from
May 15, 2019
Merged

Default value for release link env var #1958

merged 5 commits into from
May 15, 2019

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented May 15, 2019 •
edited
Loading

Motivation

There is no default value for RELEASE_LINK env var

Changelog

  • sets https://github.com/poanetwork/blockscout/releases/tag/ + $BLOCKSCOUT_VERSION for $RELEASE_LINK, if it is not indicated

Checklist for your PR

  • I added an entry to CHANGELOG.md with this PR
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
  • I checked whether I should update the docs and did so if necessary

@ghost ghost assigned vbaranov May 15, 2019
@ghost ghost added the in progress label May 15, 2019
@vbaranov vbaranov added ready for review This PR is ready for reviews. and removed in progress labels May 15, 2019
@coveralls
Copy link

coveralls commented May 15, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build e4028137-5bfa-4205-bc6d-5e5ae83fc3e9

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.09%) to 81.821%
Files with Coverage Reduction New Missed Lines %
apps/block_scout_web/lib/block_scout_web/channels/exchange_rate_channel.ex 1 50.0%
apps/explorer/test/support/factory.ex 1 92.68%
Totals Coverage Status
Change from base Build 24b8e670-bf87-4f35-bc1b-00ba852a442d: 0.09%
Covered Lines: 4654
Relevant Lines: 5688
💛 - Coveralls

@ghost ghost added the in progress label May 15, 2019
@vbaranov vbaranov merged commit e1c7ef8 into master May 15, 2019
@ghost ghost removed the in progress label May 15, 2019
@vbaranov vbaranov deleted the default-release-link branch May 15, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

@ayrat555 ayrat555 ayrat555 approved these changes

@saneery saneery saneery approved these changes

@pasqu4le pasqu4le pasqu4le approved these changes

Assignees

@vbaranov vbaranov

Labels
ready for review This PR is ready for reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vbaranov @coveralls @zachdaniel @ayrat555 @saneery @pasqu4le