feat: add on demand fetching and stale attr to rpc #1941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1891
Motivation
We want to trigger a balance fetch on any stale balances when they are retrieved via the API, not only when they are viewed in the UI. So that consumers would know, I added an attribute to the response called "stale" that is set to
true
when we have determined that the balance is old and is worth checking again. This doesn't mean that the balance is wrong (it will usually be right), it just means that we haven't seen an update for it in the last 24 hours, so we're going to check it again.Changelog
Enhancements
Fetch coin balance on demand for API requests.
CHANGELOG.md
with this PR